The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Bug #11199

PMT should rewritten to be a regular library

Added by Kelsey Hightower over 2 years ago. Updated 4 months ago.

Status:AcceptedStart date:12/06/2011
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:pmtSpent time:-
Target version:PMT v3
Keywords: Affected URL:
Branch:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This ticket is now tracked at: https://tickets.puppetlabs.com/browse/FORGE-34


Description

Based on a recent code review it has been highlighted that the PMT applications should be rewritten to be a regular library driven by the face, rather than being an old-style puppet application that we invoke in strange ways inside other applications.

History

#1 Updated by Daniel Pittman over 2 years ago

  • Status changed from Unreviewed to Accepted
  • Assignee set to Nigel Kersten

Aside from anything else, Nigel, this ties the internals of a face to our old application infrastructure in some very odd ways. Can you work out scheduling for getting it cleaned up?

#2 Updated by Nigel Kersten over 2 years ago

  • Assignee changed from Nigel Kersten to Daniel Pittman

Isn’t this covered by the general “move it to a Face” work? I’m a little confused. :)

#3 Updated by Daniel Pittman over 2 years ago

  • Assignee changed from Daniel Pittman to Kelsey Hightower

Nigel Kersten wrote:

Isn’t this covered by the general “move it to a Face” work? I’m a little confused. :)

Not in the first round, no, hence the bug. I have moved it to the appropriate engineer now. :)

#4 Updated by Ken Barber almost 2 years ago

  • Project changed from Puppet Forge to Puppet

#5 Updated by Ken Barber almost 2 years ago

  • Category set to module tool

#6 Updated by Nigel Kersten over 1 year ago

  • Project changed from Puppet to Puppet Forge
  • Category deleted (module tool)
  • Assignee changed from Kelsey Hightower to Ryan Coleman

#7 Updated by Ryan Coleman over 1 year ago

  • Status changed from Accepted to Closed

Though we need to deprecate the gem, PMT has long been a face shipping as part of Puppet. Closing this ticket.

#8 Updated by Daniel Pittman over 1 year ago

  • Status changed from Closed to Re-opened

Ryan Coleman wrote:

Though we need to deprecate the gem, PMT has long been a face shipping as part of Puppet. Closing this ticket.

This is not “please ship PMT as a face”, this is “please rewrite PMT so that it doesn’t include a full, alternative "application” framework, and implement every operation by invoking “run” as if from the command-line.

The easiest way to identify if this is done or not is to check if https://github.com/puppetlabs/puppet/blob/3.0.x/lib/puppet/module_tool/applications.rb has been deleted. If not, you probably have not rewritten this into a regular library at all.

Ditto https://github.com/puppetlabs/puppet/blob/3.0.x/lib/puppet/module_tool/applications/application.rb.

If you just delete both of those, then fix things so that PMT works again, you should be in much better shape.

#9 Updated by Ryan Coleman over 1 year ago

  • Category set to pmt
  • Status changed from Re-opened to Accepted
  • Assignee deleted (Ryan Coleman)

Daniel Pittman wrote:

Ryan Coleman wrote:

Though we need to deprecate the gem, PMT has long been a face shipping as part of Puppet. Closing this ticket.

This is not “please ship PMT as a face”, this is “please rewrite PMT so that it doesn’t include a full, alternative "application” framework, and implement every operation by invoking “run” as if from the command-line.

The easiest way to identify if this is done or not is to check if https://github.com/puppetlabs/puppet/blob/3.0.x/lib/puppet/module_tool/applications.rb has been deleted. If not, you probably have not rewritten this into a regular library at all.

Ditto https://github.com/puppetlabs/puppet/blob/3.0.x/lib/puppet/module_tool/applications/application.rb.

If you just delete both of those, then fix things so that PMT works again, you should be in much better shape.

Ah, thank you for correcting me Daniel. Putting this ticket back into the backlog..

#10 Updated by Ryan Coleman over 1 year ago

  • Target version set to PMT v3

#11 Updated by Anonymous 4 months ago

Redmine Issue #11199 has been migrated to JIRA:

https://tickets.puppetlabs.com/browse/FORGE-34

Also available in: Atom PDF