The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Feature #11727

Add stdin parsing to puppet parser validate

Added by James Turnbull over 2 years ago. Updated over 1 year ago.

Status:ClosedStart date:01/04/2012
Priority:HighDue date:
Assignee:Andrew Parker% Done:

0%

Category:executables
Target version:2.7.20
Affected Puppet version: Branch:https://github.com/puppetlabs/puppet/pull/876
Keywords:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This issue is currently not available for export. If you are experiencing the issue described below, please file a new ticket in JIRA. Once a new ticket has been created, please add a link to it that points back to this Redmine ticket.


Description

Git pre-commit hooks everywhere relied on the stdin parsing that existed before faces. This restores that behavior if stdin is not a tty.

History

#1 Updated by James Turnbull over 2 years ago

  • Assignee set to Daniel Pittman

#2 Updated by Daniel Pittman over 2 years ago

  • Assignee changed from Daniel Pittman to Dominic Maraglia
  • Branch changed from https://github.com/puppetlabs/puppet/pull/275 to https://github.com/puppetlabs/puppet/pull/329

I have written an acceptance test for this, and it is now pending review from our QA team to make sure the test is solid.

#3 Updated by Dominic Maraglia about 2 years ago

  • Assignee changed from Dominic Maraglia to Daniel Pittman

Review complete. Comments added to pull request.

#4 Updated by Daniel Pittman about 2 years ago

  • Assignee changed from Daniel Pittman to Dominic Maraglia

Dominic Maraglia wrote:

Review complete. Comments added to pull request.

Thanks, tyop fixed, can you validate again, please?

#5 Updated by Dominic Maraglia about 2 years ago

  • Assignee changed from Dominic Maraglia to Daniel Pittman

Test looks good; commented on pull request as well.

#6 Updated by Daniel Pittman about 2 years ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release
  • Target version set to 2.7.10

This is merged into master, and should shortly merge into 2.7.10, pending confirmation that it actually passes tests.

#8 Updated by Andrew Parker almost 2 years ago

  • Status changed from Merged - Pending Release to Code Insufficient
  • Assignee changed from Daniel Pittman to Andrew Parker
  • Target version changed from 2.7.10 to 2.7.18

It looks like this was supposed to make it into 2.7, but the pull request targeted master which has turned into Telly. I am redoing the pull request against 2.7.x.

#9 Updated by Andrew Parker almost 2 years ago

  • Status changed from Code Insufficient to In Topic Branch Pending Review
  • Branch changed from https://github.com/puppetlabs/puppet/pull/329 to https://github.com/puppetlabs/puppet/pull/876

Opened a new PR for 2.7.x

thinking about this I’m not sure why I did a PR, but at least this way it will be tracked :)

#10 Updated by Andrew Parker over 1 year ago

  • Target version changed from 2.7.18 to 2.7.x

#11 Updated by Daniel Pittman over 1 year ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release
  • Target version changed from 2.7.x to 2.7.20

#12 Updated by Moses Mendoza over 1 year ago

Released in 3.0.0-rc6, pending release in 2.7.x.

#13 Updated by Matthaus Owens over 1 year ago

  • Status changed from Merged - Pending Release to Closed

Released in Puppet 2.7.20

Also available in: Atom PDF