The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Feature #11862

Print client name in log lines related to client

Added by Kamil Swiatkowski over 2 years ago. Updated about 2 years ago.

Status:Requires CLA to be signedStart date:01/10/2012
Priority:NormalDue date:
Assignee:Kamil Swiatkowski% Done:

0%

Category:logging
Target version:-
Affected Puppet version:2.6.0 Branch:
Keywords:simplefix

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This ticket may be automatically exported to the PUP project on JIRA using the button below:


Description

Hi,

it would be nice to have client name (hostname) printed in log line related to this client. In large environment (in my case > 1000 clients per puppet server) it’s not possible to trace which log line belongs to which client. For example: I recently upgraded server and clients from 0.24 to 2.7 and still have some clients running 0.24. From log line like below I can’t figure out hostname of server running 0.24 client:

Jan 10 15:04:13 puppetserver puppet-master[22986]: Stages are not supported by 0.24.x client; stage(s) Stage[main] will be ignored

I modified resource/catalog.rb to report name of client like this:

Jan 10 15:04:13 puppetserver puppet-master[22986]: Stages are not supported by 0.24.x client; stage(s) Stage[main] will be ignored on xxxxx.local

I attached the patch for this.

Kamil

catalog_stages_log.diff Magnifier (725 Bytes) Kamil Swiatkowski, 01/10/2012 06:16 am

History

#1 Updated by Kelsey Hightower over 2 years ago

Kamil,

Thanks for the patch! To help get your feature/patch reviewed, can you take a look at the following guide to contributing to Puppet?

https://github.com/puppetlabs/puppet/blob/master/CONTRIBUTING.md

Mainly you will need to sign a Contributor License Agreement, if you have not done so already. Next fork the Puppet Repo on github.com, branch, patch and submit a pull request.

Let me know if you have any questions or need help with any steps to contributing.

#2 Updated by Kelsey Hightower over 2 years ago

  • Status changed from Unreviewed to Needs Decision

#3 Updated by James Turnbull over 2 years ago

  • Category set to logging
  • Status changed from Needs Decision to Requires CLA to be signed
  • Assignee set to Kamil Swiatkowski

#4 Updated by Dominic Cleal about 2 years ago

  • Affected Puppet version set to 2.6.0
  • Keywords set to simplefix

#5 Updated by Daniel Pittman about 2 years ago

Without a signed CLA we can’t use the submitted code. A reimplementation should be simple enough, however.

Also available in: Atom PDF