The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Bug #15494

puppet parser validate returns zero on nonexistent file

Added by david boldt almost 2 years ago. Updated 5 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:executables
Target version:3.4.0
Affected Puppet version:2.7.17 Branch:https://github.com/puppetlabs/puppet/pull/1926
Keywords:errors

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This issue is currently not available for export. If you are experiencing the issue described below, please file a new ticket in JIRA. Once a new ticket has been created, please add a link to it that points back to this Redmine ticket.


Description

% ls -l /foo /foo: No such file or directory

% puppet parser validate /foo ; echo $? 0


Related issues

Related to Puppet - Bug #16384: `puppet parser validate` tells me to use help when invoke... Closed 09/12/2012
Related to Puppet - Bug #17017: Improve puppet's error handling and exit code correctness. Accepted
Duplicated by Puppet - Bug #18378: puppet parser validate returns no output on nonexistent file Duplicate 07/12/2012
Duplicated by Puppet - Bug #22457: puppet parser validate does not check for non existent files Duplicate

History

#1 Updated by eric sorenson over 1 year ago

  • Description updated (diff)
  • Status changed from Unreviewed to Accepted
  • Assignee set to eric sorenson

Seems reasonable, though it might be considered good that one bad file in a long list of them on the commandline doesn’t blow up the whole run.

#2 Updated by david boldt over 1 year ago

I concur that with multiple input files the run should be finished, but believe it should exit with a nonzero return code if there is an error accessing any file. As a Unix precedent example, this is what cat does.

#3 Updated by eric sorenson over 1 year ago

  • Keywords set to errors

#4 Updated by eric sorenson over 1 year ago

Aggregating this with other error message / exit code bugs.

#5 Updated by eric sorenson over 1 year ago

  • Parent task set to #17017

#6 Updated by eric sorenson over 1 year ago

  • Parent task deleted (#17017)

#7 Updated by Zack Smith over 1 year ago

+1

#8 Updated by Adrien Thebo 7 months ago

  • Status changed from Accepted to Merged - Pending Release
  • Assignee deleted (eric sorenson)
  • Target version set to 3.4.0
  • Support Urls set to parser exit value
  • Branch set to https://github.com/puppetlabs/puppet/pull/1926

Merged into master in 3b11a10; this should be released in 3.4.0.

#9 Updated by Melissa Stone 5 months ago

  • Status changed from Merged - Pending Release to Closed

Released in Puppet 3.4.0-rc1

#10 Updated by Melissa Stone 5 months ago

Released in Puppet 3.4.0-rc1

#11 Updated by Melissa Stone 5 months ago

Released in Puppet 3.4.0-rc1

#12 Updated by Melissa Stone 5 months ago

Released in Puppet 3.4.0-rc1

#13 Updated by Melissa Stone 5 months ago

Released in Puppet 3.4.0-rc1

#14 Updated by Melissa Stone 5 months ago

Released in Puppet 3.4.0-rc1

Also available in: Atom PDF