The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Bug #15548

(puppetlabs-apt) Handling of apt update refreshonly setting.

Added by Craig Dunn almost 3 years ago. Updated almost 3 years ago.

Status:RejectedStart date:07/16/2012
Priority:HighDue date:
Assignee:-% Done:

0%

Category:-Spent time:-
Target version:-
Keywords: Branch:https://github.com/puppetlabs/puppetlabs-apt/pull/80

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com


Description

The base class had an interesting way of trying to override the refresh only parameter of the exec for apt update…

if $always_apt_update == true {     
    Exec <| title=='apt_update' |> {
      refreshonly => false,
    }
}

I’m pretty sure that has never worked – it caused it to fail many tests with;

 1) apt when specifying class parameters
     Failure/Error: it { should include_class("apt::params") }
     Puppet::Error:
       Puppet::Parser::Compiler failed with error ArgumentError: wrong number of arguments (1 for 0)

This patch makes all spec tests pass.

History

#1 Updated by Craig Dunn almost 3 years ago

  • Status changed from In Topic Branch Pending Review to Rejected

This seems to be an issue with ruby 1.9.3 support rather than the module itself – it works in 1.8.7 so Im going to close this off and raise a separate ticket against Puppet core after some more testing

Also available in: Atom PDF