The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Bug #15708

packages should be built using pkgbuild

Added by Clay Caviness over 1 year ago. Updated 8 months ago.

Status:ClosedStart date:07/26/2012
Priority:NormalDue date:
Assignee:Chris Barker% Done:

0%

Category:OSX
Target version:-
Affected Puppet version: Branch:
Keywords:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This issue is currently not available for export. If you are experiencing the issue described below, please file a new ticket in JIRA. Once a new ticket has been created, please add a link to it that points back to this Redmine ticket.


Description

Currently, OS X packages for puppet and facter are built using ./conf/osx/createpackage.sh, which calls /Developer/usir/bin/packagemaker to create the package. In recent Xcode releases, PackageMaker is no longer installed by default, and when it is installed in frequently not installed at that path. A better tool to use would be /usr/bin/pkgbuild.

History

#1 Updated by James Turnbull over 1 year ago

  • Status changed from Unreviewed to Needs Decision
  • Assignee set to eric sorenson

#2 Updated by eric sorenson over 1 year ago

  • Assignee changed from eric sorenson to Michael Stahnke

Mike this is purely a build-time thing, can your team investigate?

#3 Updated by Clay Caviness over 1 year ago

May be missing some options, but this seems to have worked, in createpackage.sh:

  "${PKGBUILD}" --root "${pkgroot}" \
                --scripts ${pkgtemp}/scripts \
                --identifier com.reductivelabs.puppet \
                --version ${puppet_version} \
                --install-location / \
                --ownership preserve \
                --verbose \
                "$(pwd)/puppet-${puppet_version}.pkg"

There’s no longer any need for the PackageInfo.plist.

#4 Updated by Clay Caviness over 1 year ago

Same issue with the facter package – do you want a separate bug in that queue?

#5 Updated by Clay Caviness over 1 year ago

Ah, also the preflight script should be called preinstall for pkgbuild.

#6 Updated by Matthaus Owens over 1 year ago

We actually build currently using the package:apple rake task. If that should be moved to use pkgbuild instead of packagemaker, that is feasible.

#7 Updated by Moses Mendoza over 1 year ago

  • Assignee changed from Michael Stahnke to Gary Larizza

Gary, handing off to you to take a look.

#8 Updated by Gary Larizza over 1 year ago

  • Assignee changed from Gary Larizza to Chris Barker

I had a conversation with Chris about this today – so I’m going to transfer this one to him. Chris, Moses has started a project here —> https://github.com/puppetlabs/packaging to specifically target packaging all of Puppet’s components. All changes need to be made to that project. It should abstract our current Rake process.

#9 Updated by Chris Barker over 1 year ago

Packaging’s apple.task has been updated to allow for building with pkgbuild and flat packages.

The facter project also requires an update to be compatible with this process: https://github.com/puppetlabs/facter/pull/374

Pull request here: https://github.com/puppetlabs/packaging/pull/87

#10 Updated by Clay Caviness 10 months ago

What’s the status of this? I see the pull requests are still pending, and I’m not sure how to use the new packaging system in any case.

Should I create a pull request for my patched createpackage.sh files in facter and puppet, or just wait for this?

Thanks

#11 Updated by Chris Barker 10 months ago

The packaging task repo (not createpackages).sh needs to be updated to merge with the latest builds of Puppet, that will be planned for later this week for update and testing (that gets integrated into our build process system).

#12 Updated by Clay Caviness 9 months ago

Any updates?

#13 Updated by Clay Caviness 9 months ago

I created https://github.com/puppetlabs/packaging/pull/171 to use pkgbuild; it probably needs some changes before integration, but hopefully it’ll get things moving.

#14 Updated by Moses Mendoza 8 months ago

  • Status changed from Needs Decision to Closed

Also available in: Atom PDF