The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

This issue tracker is now in read-only archive mode and automatic ticket export has been disabled. Redmine users will need to create a new JIRA account to file tickets using https://tickets.puppetlabs.com. See the following page for information on filing tickets with JIRA:

Bug #16122

mounttab type defaults cause pass and dump to change

Added by Dominic Cleal over 3 years ago. Updated about 3 years ago.

Status:UnreviewedStart date:08/25/2012
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:mount-providersSpent time:-
Target version:-
Keywords:mounttab Branch:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com


Description

The pass and dump properties of mounttab have defaults of “0” defined in the type. When running a resource without these specified, existing values set in the fstab get changed to the defaults. Expected behaviour would be to only use the defaults when creating a new entry.

Example:

file { "/tmp/fstab-pass-test":
  content => "LABEL=foo /test ext4 noatime 1 2",
}

mounttab { "/test":
  target  => "/tmp/fstab-pass-test",
  device  => "LABEL=bar",
  require => File["/tmp/fstab-pass-test"],
}

Log:

/Stage[main]//File[/tmp/fstab-pass-test]/ensure: defined content as '{md5}2fbfddf5fc3ef4540e6569ea1f80e89a'
/Stage[main]//Mounttab[/test]/device: device changed 'LABEL=foo' to 'LABEL=bar'
/Stage[main]//Mounttab[/test]/pass: pass changed '2' to '0'
/Stage[main]//Mounttab[/test]/dump: dump changed '1' to '0'

Actual file contents:

# HEADER: This file was autogenerated at 2012-08-25 16:27:42 +0100
# HEADER: by puppet.  While it can still be managed manually, it
# HEADER: is definitely not recommended.
LABEL=bar   /test   ext4    noatime 0   0

Expected:

LABEL=bar   /test   ext4    noatime 1   2

History

#1 Updated by Dominic Cleal over 3 years ago

This also affects “atboot” and “options” for Solaris vfstab, which both set defaults.

Also available in: Atom PDF