The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

This issue tracker is now in read-only archive mode and automatic ticket export has been disabled. Redmine users will need to create a new JIRA account to file tickets using https://tickets.puppetlabs.com. See the following page for information on filing tickets with JIRA:

Bug #16567

Remove completely useless "lexical" setting that apparently dates back to 0.17.0

Added by Nick Fagerlund over 3 years ago. Updated over 3 years ago.

Status:ClosedStart date:09/24/2012
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:settings
Target version:3.0.0
Affected Puppet version: Branch:
Keywords:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com


Description

defaults.rb, line 1489, 3.x branch:

# This doesn't actually work right now.

  define_settings(
  :parser,

  :lexical => {
    :default  => false,
    :type     => :boolean,
    :desc     => "Whether to use lexical scoping (vs. dynamic).",
  },

WAT.

nick@magpie:~/Documents/puppet/lib [3.x]$ ack lexical
puppet/defaults.rb
1494:    :lexical => {
1497:      :desc     => "Whether to use lexical scoping (vs. dynamic).",

puppet/parser/compiler.rb
70:    # This adds a resource to the class it lexically appears in in the

WAT. *blizzard of git blame and git show windows*

commit 0819e35be74bc997c3a953f05bab874b8d76429d
Author: luke <luke@980ebf18-57e1-0310-9a29-db15c13687c0>
Date:   Sat May 13 02:14:35 2006 +0000

    Adding some small changes towards fixing #140 and #83, but this work needs to take a back seat to object collection, so i will come back to it later.

    git-svn-id: https://reductivelabs.com/svn/puppet/trunk@1186 980ebf18-57e1-0310-9a29-db15c13687c0

WAAAAATTTTTTTTTTTTTTTTT

nick@magpie:~/Documents/puppet/lib [3.x]$ git name-rev 0819e35b
0819e35b tags/0.17.0~15

WAT.

Maybe let’s kill this.

History

#1 Updated by Nick Fagerlund over 3 years ago

  • Category set to settings
  • Assignee set to Anonymous

And yes, this was committed with a comment saying it didn’t work, and was only referenced by commented-out code, which was later removed.

#2 Updated by James Turnbull over 3 years ago

Oh that’s an old classic. When I first found it I was like “WAT! WTF!?” and then when I traced the history and the code path I became a sad panda.

#3 Updated by eric sorenson over 3 years ago

Technically “get back to it later” is true.

#4 Updated by Anonymous over 3 years ago

  • Status changed from Unreviewed to Merged - Pending Release
  • Target version set to 3.0.0

Merged in commit 26554ee

#5 Updated by Matthaus Owens over 3 years ago

  • Status changed from Merged - Pending Release to Closed

Released in Puppet 3.0.0-rc8

Also available in: Atom PDF