The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

This issue tracker is now in read-only archive mode and automatic ticket export has been disabled. Redmine users will need to create a new JIRA account to file tickets using https://tickets.puppetlabs.com. See the following page for information on filing tickets with JIRA:

Feature #1696

Add support for branded zones

Added by Clayton O'Neill almost 7 years ago. Updated almost 7 years ago.

Status:ClosedStart date:10/27/2008
Priority:NormalDue date:
Assignee:James Turnbull% Done:

0%

Category:Solaris
Target version:0.24.7
Affected Puppet version:0.24.5 Branch:
Keywords:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com


Description

This patch adds two new parameters on the zone type, and the backing provider support. The parameters are create_args and install_args. These are passed to the zonecfg create and zoneadm install commands, respectively. I implemented these so that I could create solaris8 branded zones, but it’s probably useful for other things, including linux branded zones, and anything else you’d want to pass these arguments in for.

0002-Add-support-for-branded-zones.patch Magnifier (2.08 KB) Clayton O'Neill, 10/27/2008 11:38 pm

0002-Add-support-for-branded-zones.patch Magnifier - Fixed patch (2.18 KB) Clayton O'Neill, 10/30/2008 02:45 pm

History

#1 Updated by James Turnbull almost 7 years ago

  • Category set to Solaris
  • Status changed from Unreviewed to Accepted
  • Assignee set to Andrew Shafer
  • Target version set to 0.24.7

#2 Updated by Clayton O'Neill almost 7 years ago

Attached is a fixed patch. Original patch would break non-branded zones.

#3 Updated by Andrew Shafer almost 7 years ago

There are no tests for this. (not just for the patch, at all)

I think I can get them spec’d up this week.

Not knowing anything at all about branded zones (and not much more about zones for that matter) it’s hard for me to judge what is the most appropriate way to manage them. But… I think it is worth exploring managing these with a little more semantic detail.

The commands should not be a single ‘space’ delimited string, at least pass in any array.

The zone provider also has no way to really manage zone attributes. It looks like the management is only one direction and can’t go back to change the attributes of a zone that already exists. That’s a limitation for the moment, but solving that generically seems like a good idea. (but probably not for this simple patch.)

I’d like to talk with coneill about what the command actually look like and then decide if it makes sense to break them out into parameters in the type.

#4 Updated by Luke Kanies almost 7 years ago

I agree with Andrew — the args should be an array of arguments, rather than a string that you split based on whitespace.

#5 Updated by James Turnbull almost 7 years ago

  • Status changed from Accepted to Code Insufficient
  • Assignee changed from Andrew Shafer to Clayton O'Neill
  • 3 changed from Unknown to Trivial

See comments.

#6 Updated by James Turnbull almost 7 years ago

  • Status changed from Code Insufficient to Tests Insufficient
  • Assignee changed from Clayton O'Neill to Andrew Shafer

#7 Updated by Andrew Shafer almost 7 years ago

  • Status changed from Tests Insufficient to Ready For Checkin
  • Assignee changed from Andrew Shafer to James Turnbull

ticket/0.24.x/1696

#8 Updated by James Turnbull almost 7 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:3eff2254e69cf66b6e9f94631900fba26172c850 in branch 0.24.x

Also available in: Atom PDF