The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

This issue tracker is now in read-only archive mode and automatic ticket export has been disabled. Redmine users will need to create a new JIRA account to file tickets using https://tickets.puppetlabs.com. See the following page for information on filing tickets with JIRA:

Bug #19989

virtual fact with virt-what installed produces bogus output for non-root users

Added by Todd Zullinger about 3 years ago. Updated about 3 years ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:1.7.0
Keywords: Affected Facter version:1.6.18
Branch:https://github.com/tmzullinger/facter/branches/tickets/1.6.x/19989-virt-what-ignore-cruft

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com


Description

When the virt-what program is present, facter tries to use this via Facter::Util::Virtual.virt_what. The problem is that virt-what only produces a warning to stdout for non-root users.

$ facter —version; facter virtual 1.6.18 virt-what: this script must be run as root

There is a long-standing bug for virt-what to work as non-root¹, but until that is resolved, facter should not rely on its output when run as non-root.

¹ https://bugzilla.redhat.com/show_bug.cgi?id=719611


Related issues

Related to Facter - Bug #20072: facter fails to redirect virt-what stderr to /dev/null on... Closed

History

#1 Updated by Todd Zullinger about 3 years ago

Damn formatting…

$ facter --version; facter virtual
1.6.18
virt-what: this script must be run as root

#2 Updated by Todd Zullinger about 3 years ago

  • Status changed from Unreviewed to In Topic Branch Pending Review
  • Branch set to https://github.com/tmzullinger/facter/branches/tickets/1.6.x/19989-virt-what-ignore-cruft

I submitted a pull request for a fix to ignore bogus virt-what: output, until virt-what is changed to not send such output to stdout.

https://github.com/puppetlabs/facter/pull/413

#3 Updated by Josh Cooper about 3 years ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release
  • Target version set to 1.7.0

Merged into 1.7.x in commit b7784a3af80c70a833dfd3de1fa32dc1eb62384e

#4 Updated by Matthaus Owens about 3 years ago

  • Status changed from Merged - Pending Release to Closed

Released in Facter 1.7.0-rc2

Also available in: Atom PDF