The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Bug #2118

Puppetmasterd should finish operations when restarting

Added by Luke Kanies about 5 years ago. Updated over 1 year ago.

Status:AcceptedStart date:03/30/2009
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:plumbing
Target version:-
Affected Puppet version:0.24.7 Branch:
Keywords:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This ticket may be automatically exported to the PUP project on JIRA using the button below:


Description

When the master gets a signal to restart, it will stop all open operations and restart immediately. It should instead finish any of those operations before restarting.

I don’t really know how this will work – I assume it will require some kind of registration process that keeps a counter of open connections, along with a lock that prevents new connections. Thus, a restart will enable this lock, and will not restart until the number of open connections has dropped to 0.

History

#1 Updated by Digant Kasundra about 5 years ago

luke wrote:

When the master gets a signal to restart, it will stop all open operations and restart immediately. It should instead finish any of those operations before restarting.

Often, we are restarting puppetmaster when it is locked or dead or perhaps hung on something it is processing. How would this play with the idea of it waiting for all connections/operations to finish? Should we except to use a hard kill instead?

#2 Updated by Luke Kanies about 5 years ago

digant wrote:

Often, we are restarting puppetmaster when it is locked or dead or perhaps hung on something it is processing. How would this play with the idea of it waiting for all connections/operations to finish? Should we except to use a hard kill instead?

If puppetmasterd is hung, then yes, you would expect to need to use a hard kill.

Hopefully, more closely tracking what requests are open and which are not returning would be a straightforward way to give us an idea of which requests are hanging, which should help us resolve those problems.

#3 Updated by James Turnbull about 4 years ago

  • Target version changed from 2.6.0 to 2.7.x

#4 Updated by Luke Kanies almost 4 years ago

  • Assignee changed from Luke Kanies to Markus Roberts

#5 Updated by Joshua Lifton over 2 years ago

  • Assignee deleted (Markus Roberts)

This issue was assigned to a former Puppet Labs employee. Adding back to the pool of unreviewed issues.

#6 Updated by Joshua Lifton over 2 years ago

This issue was assigned to a former Puppet Labs employee. Adding back to the pool of unreviewed issues.

#7 Updated by Ben Hughes over 2 years ago

  • Description updated (diff)
  • Status changed from Accepted to Unreviewed

#8 Updated by Luke Kanies over 2 years ago

  • Description updated (diff)
  • Status changed from Unreviewed to Accepted

#9 Updated by Andrew Parker over 1 year ago

  • Target version deleted (2.7.x)

Also available in: Atom PDF