The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

This issue tracker is now in read-only archive mode and automatic ticket export has been disabled. Redmine users will need to create a new JIRA account to file tickets using https://tickets.puppetlabs.com. See the following page for information on filing tickets with JIRA:

Bug #5221

0.24/2.6 pluginsync broken: "Fileset paths must be fully qualified" error when paths have a trailing /

Added by Tim Edwards over 5 years ago. Updated about 5 years ago.

Status:ClosedStart date:11/08/2010
Priority:HighDue date:
Assignee:-% Done:

0%

Category:fileserving
Target version:2.6.8
Affected Puppet version: Branch:http://github.com/jamtur01/puppet/tree/tickets/2.6.x/5221
Keywords:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com


Description

I had the following in one of my manifests:

tidy { yumconf:
path => "/etc/",
recurse => true,
matches => [ "yum.conf.rpmnew", "yum.conf.rpmsave" ]
}

This produced the error:

err: /Stage[main]/Yum::Config/Tidy[yumconf]: Failed to generate additional resources using 'generate': Fileset paths must be fully qualified

The workaround was to change it to:

path => "/etc"

Related issues

Duplicated by Puppet - Bug #6001: 0.24.8 client to 2.6.4 server has Fileset path error Duplicate 01/25/2011

History

#1 Updated by Tim Edwards over 5 years ago

The following line /usr/lib/ruby/site_ruby/1.8/puppet/file_serving/fileset.rb in should be changed to chomp any extra /’s:

raise ArgumentError.new("Fileset paths must be fully qualified") unless File.expand_path(path) == path

In Unix both /etc/ and /etc are equally valid so the code should reflect this to avoid needless confusion like I had.

#2 Updated by Nigel Kersten over 5 years ago

  • Status changed from Unreviewed to Accepted
  • Assignee set to Nigel Kersten

Ugh. Tim did you want to send this to the dev list?

http://projects.puppetlabs.com/projects/puppet/wiki/Development_Development_Lifecycle

or would you like one of us to do it on your behalf?

#3 Updated by Tim Edwards over 5 years ago

If you could do it would be great, I’m just a user of puppet – I don’t have a Git check-out of it nor any development tools or setup for it.

#4 Updated by Nigel Kersten over 5 years ago

  • Assignee deleted (Nigel Kersten)

#5 Updated by James Turnbull over 5 years ago

  • Category set to fileserving
  • Status changed from Accepted to In Topic Branch Pending Review
  • Target version set to 2.6.5
  • Branch set to http://github.com/jamtur01/puppet/tree/tickets/2.6.x/5221

#6 Updated by Paul Berry about 5 years ago

  • Status changed from In Topic Branch Pending Review to Tests Insufficient

This patch looks great, but we need to write a unit test before merging it into the code base.

#7 Updated by R.I. Pienaar about 5 years ago

commenting on the right ticket…I can confirm the original issue with pluginsync from 0.24.8 to 2.6.4. Have applied this patch to the 2.6.4 master and it solves it without needing to tweak any clients.

It would be fantastic if this can go into 2.6.5

#8 Updated by Nigel Kersten about 5 years ago

  • Target version changed from 2.6.5 to 2.6.x

#9 Updated by Nigel Kersten about 5 years ago

We’re still looking for tests I believe.

#10 Updated by James Turnbull about 5 years ago

  • Target version changed from 2.6.x to 2.6.6

#11 Updated by Nigel Kersten about 5 years ago

  • Target version changed from 2.6.6 to 2.6.x

We clearly need to resolve this. I’d missed the duplicated ticket where this was the actual problem with 0.24.8 pluginsync.

#12 Updated by Nigel Kersten about 5 years ago

  • Subject changed from "Fileset paths must be fully qualified" error when paths have a trailing / to 0.24/2.6 pluginsync broken: "Fileset paths must be fully qualified" error when paths have a trailing /
  • Priority changed from Normal to High

#13 Updated by James Turnbull about 5 years ago

  • Status changed from Tests Insufficient to Closed
  • Target version changed from 2.6.x to 2.6.8

Also available in: Atom PDF