The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Bug #7194

The cisco switch management feature shouldn't have a type called interface

Added by Matt Robinson almost 3 years ago. Updated 10 months ago.

Status:AcceptedStart date:04/20/2011
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:-
Target version:-
Affected Puppet version: Branch:
Keywords:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This ticket may be automatically exported to the PUP project on JIRA using the button below:


Description

The recent merge of the network device code Brice wrote includes a type called interface. lib/puppet/type/interface.rb. This is an awfully confusing name given the recent “faces” feature has a bunch of code behind the scenes called interface. Let’s think of a better name for this type and change it. network_interface maybe?

╭─[~/work/puppet/lib]─[matthewrobinson@mattmac]─[20110420 - 15:33]-‹2.7.x*› 
╰─ % find . -name "*interface*"                                                                                     
./puppet/interface
./puppet/interface.rb
./puppet/provider/interface
./puppet/ssl/certificate_authority/interface.rb
./puppet/type/interface.rb
./puppet/util/network_device/cisco/interface.rb

History

#1 Updated by Daniel Pittman almost 3 years ago

NB: The puppet/ssl/certificate_authority/interface.rb file is slated to be replaced with a real face after 2.7.0

#2 Updated by Brice Figureau almost 3 years ago

Matt Robinson wrote:

The recent merge of the network device code Brice wrote includes a type called interface. lib/puppet/type/interface.rb. This is an awfully confusing name given the recent “faces” feature has a bunch of code behind the scenes called interface. Let’s think of a better name for this type and change it. network_interface maybe?

╭─[~/work/puppet/lib]─[matthewrobinson@mattmac]─[20110420 - 15:33]-‹2.7.x*› 
╰─ % find . -name "*interface*"                                                                                     
./puppet/interface
./puppet/interface.rb
./puppet/provider/interface
./puppet/ssl/certificate_authority/interface.rb
./puppet/type/interface.rb
./puppet/util/network_device/cisco/interface.rb

We can make it: “device_if” or “net_if”. I’d really like puppet would support namespaced builtin types, but it isn’t :( If you can wait until early next week, I can come with a patch.

#3 Updated by Nigel Kersten almost 3 years ago

  • Status changed from Unreviewed to Accepted

Also available in: Atom PDF