The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

This issue tracker is now in read-only archive mode and automatic ticket export has been disabled. Redmine users will need to create a new JIRA account to file tickets using https://tickets.puppetlabs.com. See the following page for information on filing tickets with JIRA:

Bug #7791

puppet should reject certain options when running mount -o

Added by Stefan Schulte over 4 years ago. Updated almost 2 years ago.

Status:ClosedStart date:06/05/2011
Priority:LowDue date:
Assignee:-% Done:

0%

Category:-
Target version:3.3.0
Affected Puppet version: Branch:https://github.com/puppetlabs/puppet/pull/1699
Keywords:

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com


Description

currently puppet does always mount a device with -o options. For certain options this is not desired.

e.g. when you have the following manifest:

mount { '/foo':
  ...
  options => '-',
}

The ‘–’ on Solaris indicates that I dont want to mount with special mountoptions and this is a valid option in vfstab. This option is however not valid when running mount. In this case the Solaris mount command will print a warning (something like »unrecognized option, ignoring this option« and just because puppet normally doesnt print any output you dont see this message).

Because the mountprovider works I think this is a low priority issue, but it’ll be more sane if puppet just rejects special options like ‘–’ and ‘defaults’ when running mount -o

History

#1 Updated by Ben Hughes about 4 years ago

  • Status changed from Unreviewed to Investigating

Hi Stefan. Thank you for the report with that. The newer mountpoint module work that we’ve been working on will address this.

#2 Updated by Stefan Schulte about 2 years ago

  • Status changed from Investigating to In Topic Branch Pending Review
  • Branch set to https://github.com/puppetlabs/puppet/pull/1699

#3 Updated by Stefan Schulte about 2 years ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release
  • Target version set to 3.3.0

Issue fixed in PR/1699 and merged into master in 67e1ff6. This should be released in 3.3.0.

#4 Updated by Anonymous almost 2 years ago

  • Status changed from Merged - Pending Release to Closed

Released in 3.3.0

#5 Updated by Anonymous almost 2 years ago

Released in 3.3.0

Also available in: Atom PDF