The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Bug #8808

No error when an Augeas resource cannot be saved

Added by Dominic Cleal over 2 years ago. Updated over 2 years ago.

Status:ClosedStart date:08/06/2011
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:augeas
Target version:2.7.4
Affected Puppet version:2.7.0 Branch:https://github.com/domcleal/puppet/tree/tickets/2.7.x/8808
Keywords:augeas error

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This issue is currently not available for export. If you are experiencing the issue described below, please file a new ticket in JIRA. Once a new ticket has been created, please add a link to it that points back to this Redmine ticket.


Description

The Augeas provider no longer fails with an error if saving fails and only reports “no need to run”.

With the following manifest:

augeas { "broken":
  changes => "set /files/etc/fstab/*[last()]/foo bar",
}

Prior to #2728 being applied:

err: /Stage[main]/Augeas/Augeas[broken]/returns: change from need_to_run to 0 failed: Save failed with return code false

Related issues

Related to Puppet - Feature #5606: augeas needs more detailed error printing Closed 12/19/2010
Related to Puppet - Feature #2728: augeas show print file changes as applicable via --show_d... Closed 10/16/2009

History

#1 Updated by Dominic Cleal over 2 years ago

  • Status changed from Unreviewed to In Topic Branch Pending Review
  • Branch set to https://github.com/domcleal/puppet/tree/tickets/2.7.x/8808

Now reports:

err: /Stage[main]/Augeas/Augeas[broken]: Could not evaluate: Save failed with return code false

(The aug_save is done from need_to_run?, so it now comes up as an evaluation failure, not a “change from..to” failure).

#2 Updated by Matthaus Owens over 2 years ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release

#3 Updated by Matthaus Owens over 2 years ago

  • Status changed from Merged - Pending Release to Closed
  • Target version set to 2.7.4

Merged in 1ce2973e8af2300aff2b042257d8181855cf887d

Released in 2.7.4rc1

Also available in: Atom PDF