The Puppet Labs Issue Tracker has Moved: https://tickets.puppetlabs.com

Bug #9083

Puppet-vcsrepo fails on cvs with undefined method `working_copy_exists?'

Added by Spencer Krum over 2 years ago. Updated over 1 year ago.

Status:Merged - Pending ReleaseStart date:08/17/2011
Priority:NormalDue date:
Assignee:Michael Nelson% Done:

0%

Category:vcsrepoSpent time:-
Target version:-
Keywords: Branch:https://github.com/puppetlabs/puppet-vcsrepo/pull/12

We've Moved!

Ticket tracking is now hosted in JIRA: https://tickets.puppetlabs.com

This issue is currently not available for export. If you are experiencing the issue described below, please file a new ticket in JIRA. Once a new ticket has been created, please add a link to it that points back to this Redmine ticket.


Description

Running a manifest, even the examples, all fail with undefined method `working_copy_exists?'

Manifests to puppet apply are in the examples directory. This is for CVS

puppet apply remote.pp
warning: Found multiple default providers for vcsrepo: git, svn, cvs, hg; using git
err: /Stage[main]//Vcsrepo[/tmp/vcstest-cvs-workspace-remote]: Could not evaluate: undefined method `working_copy_exists?' for #
notice: Finished catalog run in 0.04 seconds

You can work around this by adding a working_copy_exists?

  def working_copy_exists?
    File.directory?(File.join(@resource.value(:path), 'CVS'))
  end

Then the output is:

warning: Found multiple default providers for vcsrepo: git, svn, cvs, hg; using git
notice: /Stage[main]//Vcsrepo[/tmp/vcstest-git-clone]/ensure: created
notice: Finished catalog run in 5.04 seconds

And the WEIRD thing is that it correctly gets the repository, but claims to be using git.

History

#1 Updated by James Turnbull over 2 years ago

  • Category set to vcsrepo
  • Status changed from Unreviewed to Accepted
  • Assignee set to Spencer Krum

#2 Updated by Ken Barber over 2 years ago

  • Assignee deleted (Spencer Krum)

#3 Updated by Matthias Pigulla over 2 years ago

Pull req https://github.com/puppetlabs/puppet-vcsrepo/pull/12

#4 Updated by James Turnbull over 2 years ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Branch set to https://github.com/puppetlabs/puppet-vcsrepo/pull/12

#5 Updated by James Turnbull over 2 years ago

  • Status changed from In Topic Branch Pending Review to Closed

Merged in 7d03bfca4957649f7de4bb7bb6c6d3dcc3d194db.

#6 Updated by Michael Nelson over 2 years ago

  • Status changed from Closed to Re-opened

I’ve just experienced the same error when using 0.0.4 with bzr instead of cvs, so I downloaded current trunk and tried again expecting it to be fixed – but it wasn’t.

I’ll re-open this bug (ie. generalising the title s/cvs/cvs or bzr/), but am happy to create a separate bug if you prefer. FWIW, I’ve switched to 0.0.3 and it is working without the error.

#7 Updated by James Turnbull over 2 years ago

  • Status changed from Re-opened to Code Insufficient
  • Assignee set to Michael Nelson

Michael – a patch would be great. Could you please sign a CLA (link in top right menu) also! Thanks!

#8 Updated by Daniel Johnson over 2 years ago

There is a commit in puppet-vcsrepo marked “Fix (#9083) as suggested by the original bug reporter. ” [1] that looks like it would fix the issue for CVS. The bug was reopened a few days later with the issue generalized to also include bzr version control which seems to be fixed with commit [2]. I checked the other vcs methods, and they all have working_copy_exists? defined now.

  1. https://github.com/puppetlabs/puppet-vcsrepo/commit/b5110938f5cb6736a13bbecbef4fbcaf6837ce56
  2. https://github.com/puppetlabs/puppet-vcsrepo/commit/b5110938f5cb6736a13bbecbef4fbcaf6837ce56

#9 Updated by Aaron Stone over 1 year ago

Is this now fixed in vcsrepo 0.1.0? Please update, check, and report back if this issue can be closed!

#10 Updated by Aaron Stone over 1 year ago

Is this now fixed in vcsrepo 0.1.1? Please update and test and update the ticket!

#11 Updated by Aaron Stone over 1 year ago

  • Status changed from Code Insufficient to In Topic Branch Pending Review

#12 Updated by Aaron Stone over 1 year ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release

Also available in: Atom PDF